Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAM crash #6166

Merged
merged 4 commits into from
Nov 2, 2024
Merged

LAM crash #6166

merged 4 commits into from
Nov 2, 2024

Conversation

DM0000
Copy link
Contributor

@DM0000 DM0000 commented Nov 2, 2024

added atmosphere check to willCrash in AeroPathUtil with unit test

closes #6145

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.19%. Comparing base (948ce7b) to head (336ba8f).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6166      +/-   ##
============================================
- Coverage     29.19%   29.19%   -0.01%     
+ Complexity    13975    13974       -1     
============================================
  Files          2623     2623              
  Lines        266434   266435       +1     
  Branches      47593    47594       +1     
============================================
- Hits          77776    77775       -1     
- Misses       184753   184755       +2     
  Partials       3905     3905              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DM0000
Copy link
Contributor Author

DM0000 commented Nov 2, 2024

Adjusted unit test. The isAirborneAeroOnGroundMap() from mockAero isn't being picked up by mockPath for some reason.

@SJuliez SJuliez merged commit 0f6e5b4 into MegaMek:master Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side Torso destruction forces LAM to crash-land in space
2 participants