Added TotalGenericBattleValue Tag to MUL Export
#6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the `saveTo` method in `EntityListFile` to include an optional generic battle value parameter. Added calculation and integration of generic battle value in `BriefingTab` when saving entity lists to files. This is hidden in MUL export as GBV is not meant to be user-facing. We include it here as a debugging tool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6122 +/- ##
=========================================
Coverage 29.07% 29.07%
+ Complexity 13971 13970 -1
=========================================
Files 2601 2601
Lines 267448 267443 -5
Branches 47758 47759 +1
=========================================
- Hits 77765 77764 -1
+ Misses 185788 185783 -5
- Partials 3895 3896 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the
saveTomethod inEntityListFileto include an optional generic battle value parameter.This information will be hidden in MUL export as GBV is not meant to be user-facing. We include it here as a debugging tool.
This is the MM portion of MegaMek/mekhq#5070