Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pilot tooltip exceptions #6107

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 16, 2024

Adressing the IOExceptions from #6099
This will catch exceptions from ImageIO and simply not show the pilot portrait if any occur

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (957cb42) to head (1f08323).
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6107      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13977    13970       -7     
============================================
  Files          2601     2601              
  Lines        267450   267449       -1     
  Branches      47761    47758       -3     
============================================
- Hits          77768    77764       -4     
- Misses       185775   185789      +14     
+ Partials       3907     3896      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 68f41be into MegaMek:master Oct 17, 2024
6 checks passed
@SJuliez SJuliez deleted the tooltip-portrait-exc branch October 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants