Merge Space Settings Review - Meeds-io/MIPs#147 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzmiTouil
approved these changes
Sep 26, 2024
…o/MIPs#147 (#215) This change will delete Space Banner Portlet instance and will avoid displaying blank margin coming from a Dynamic section having all its applications hidden in Mobile.
…eeds-io/MIPs#147 (#220) This change will just hide the button of Layout edition from Top Bar, so that only super administrators will be able to access it. This will avoid space manager to access this feature by UI until a rework is made on permissions model to let Platform administrators choose who will be able to access this feature and button. Besides, improving the permissions model means that the Portal MOP permission (portal layer) has to be delegated to SpaceService (social) layer which will be improved in a dedicated MIP (Space Templates).
boubaker
force-pushed
the
merge-mip-147
branch
from
cf3fc53
to
3bc812a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#147