fix: Fix Setting Permanent Link Id when set twice in two different th…

…reads - Meeds-io/MIPs#134 (#938) Prior to this change, when setting twice the same value for a permanent link id in two different threads, then one of them will through an exception. This change ensures to not throw exception when the permanent link is already set.
Meeds-io · Jul 24, 2024 · f69df08 · f69df08
1 parent 2af0c42
commit f69df08
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 5 deletions.
diff --git a/...onent/portal/src/main/java/io/meeds/portal/permlink/service/PermanentLinkServiceImpl.java b/...onent/portal/src/main/java/io/meeds/portal/permlink/service/PermanentLinkServiceImpl.java
@@ -42,6 +42,8 @@
 import org.exoplatform.commons.exception.ObjectNotFoundException;
 import org.exoplatform.container.PortalContainer;
 import org.exoplatform.container.RootContainer.PortalContainerPostCreateTask;
+import org.exoplatform.services.log.ExoLogger;
+import org.exoplatform.services.log.Log;
 import org.exoplatform.services.security.Identity;
 
 import io.meeds.portal.permlink.model.PermanentLinkObject;
@@ -53,6 +55,9 @@
 
 public class PermanentLinkServiceImpl implements PermanentLinkService, Startable {
 
+  private static final Log                 LOG                      =
+                                               ExoLogger.getLogger(PermanentLinkServiceImpl.class);
+
   public static final Context              PERMANEN_LINK_CONTEXT    = Context.GLOBAL.id("PermanentLink");
 
   public static final Scope                PERMANENT_LINK_SCOPE     = Scope.GLOBAL.id("PermanentLinkIds");
@@ -207,10 +212,21 @@ private String getById(String permanentLinkId) {
 
   private String getAndSetId(String permanentLink) {
     String permanentLinkId = generateHash(permanentLink);
-    settingService.set(PERMANEN_LINK_CONTEXT,
-                       PERMANENT_LINK_IDS_SCOPE,
-                       permanentLinkId,
-                       SettingValue.create(permanentLink));
+    try {
+      settingService.set(PERMANEN_LINK_CONTEXT,
+                         PERMANENT_LINK_IDS_SCOPE,
+                         permanentLinkId,
+                         SettingValue.create(permanentLink));
+    } catch (RuntimeException e) {
+      if (settingService.get(PERMANEN_LINK_CONTEXT,
+                             PERMANENT_LINK_IDS_SCOPE,
+                             permanentLinkId)
+          == null) {
+        throw e;
+      } else {
+        LOG.debug("Duplicated Permanent Link Id {} set. This may be due to parallel saving", permanentLinkId);
+      }
+    }
     return permanentLinkId;
   }
 

diff --git a/webui/src/main/java/org/exoplatform/portal/webui/workspace/UIPortalApplication.java b/webui/src/main/java/org/exoplatform/portal/webui/workspace/UIPortalApplication.java
@@ -1204,7 +1204,7 @@ private List<UIPortlet> getCurrentPortlets() {
       // Determine portlets visible on the page
       uiPortlets = new ArrayList<>();
       UISharedLayout sharedLayout = uiWorkingWorkspace.findFirstComponentOfType(UISharedLayout.class);
-      if (sharedLayout.isShowSharedLayout(requestContext)) {
+      if (sharedLayout == null || sharedLayout.isShowSharedLayout(requestContext)) {
         uiWorkingWorkspace.findComponentOfType(uiPortlets, UIPortlet.class);
       } else {
         UIPage currentPage = getCurrentPage();