Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Merger PR cancels gamification for user - MEED-2441 - Meeds-io/MIPs#64 #99

Merged
merged 1 commit into from
Sep 14, 2023
Merged

fix: Merger PR cancels gamification for user - MEED-2441 - Meeds-io/MIPs#64 #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...es/src/main/java/org/exoplatform/gamification/github/plugin/PullRequestTriggerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ public List<Event> getEvents(Map<String, Object> payload) {
String objectId = extractSubItem(payload, PULL_REQUEST, HTML_URL);
if (Objects.equals(extractSubItem(payload, ACTION), OPENED)) {
return Collections.singletonList(new Event(CREATE_PULL_REQUEST_EVENT_NAME, null, userId, objectId, PR_TYPE));
} else if (Objects.equals(extractSubItem(payload, ACTION), CLOSED)) {
} else if (Objects.equals(extractSubItem(payload, ACTION), CLOSED)
&& !Boolean.parseBoolean(extractSubItem(payload, PULL_REQUEST, MERGED))) {
return Collections.singletonList(new Event(CLOSE_PULL_REQUEST_EVENT_NAME, null, userId, objectId, PR_TYPE));
} else if (Objects.equals(extractSubItem(payload, ACTION), REVIEW_REQUESTED)) {
String requestedReviewer = extractSubItem(payload, REQUESTED_REVIEWER, LOGIN);
Expand Down
2 changes: 2 additions & 0 deletions ...cation-github-services/src/main/java/org/exoplatform/gamification/github/utils/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ public class Utils {

public static final String UNLABELED = "unlabeled";

public static final String MERGED = "merged";

public static final String REVIEW_REQUESTED = "review_requested";

public static final String REVIEW_REQUEST_REMOVED = "review_request_removed";
Expand Down