Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GitHub connectors List events available in a project - MEED-2301 - Meeds-io/MIPs#64 #83

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

AzmiTouil
Copy link
Contributor

Allow rewarding users to enable/disable project events


@Override
public List<String> getEvents() {
return new ArrayList<>(List.of(COMMENT_PULL_REQUEST_EVENT_NAME));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return new ArrayList<>(List.of(COMMENT_PULL_REQUEST_EVENT_NAME));
return Arrays.asList(COMMENT_PULL_REQUEST_EVENT_NAME);


@Override
public List<String> getEvents() {
return new ArrayList<>(List.of(REVIEW_PULL_REQUEST_EVENT_NAME, PULL_REQUEST_VALIDATED_EVENT_NAME));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return new ArrayList<>(List.of(REVIEW_PULL_REQUEST_EVENT_NAME, PULL_REQUEST_VALIDATED_EVENT_NAME));
return Arrays.asList(REVIEW_PULL_REQUEST_EVENT_NAME, PULL_REQUEST_VALIDATED_EVENT_NAME);

@AzmiTouil AzmiTouil merged commit 9f53748 into feature/meedsv2 Aug 17, 2023
1 check passed
@AzmiTouil AzmiTouil deleted the meed-2301 branch August 17, 2023 07:55
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

exo-swf pushed a commit that referenced this pull request Aug 28, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
AzmiTouil added a commit that referenced this pull request Sep 11, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
AzmiTouil added a commit that referenced this pull request Sep 12, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
AzmiTouil added a commit that referenced this pull request Sep 20, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
AzmiTouil added a commit that referenced this pull request Sep 20, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
exo-swf pushed a commit that referenced this pull request Sep 25, 2023
…- Meeds-io/MIPs#64 (#83)

Allow rewarding users to enable/disable project events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants