fix: No image displayed when ImageResizeService throw an error - EXO-74337 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…74337 Before this fix, in some case, the ImageResizeService can throw an error. I add a unit test with a specifi jpeg image generating this error : the jpeg metadata have different format (EXIF, JFIF ...), and jdk default image reader only support EXIF and JFIF. When a jpeg image have a different metadata format, the ImageReaderService is not able to read it, and throws an error. This commit ensure that, in this case, the service return the original image instead of nothing Resolves Meeds-io/meeds#2418 (cherry picked from commit 9e65276)
mkrout
approved these changes
Sep 24, 2024
rdenarie
approved these changes
Oct 7, 2024
akhanfir
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, in some case, the ImageResizeService can throw an error. I add a unit test with a specifi jpeg image generating this error : the jpeg metadata have different format (EXIF, JFIF ...), and jdk default image reader only support EXIF and JFIF. When a jpeg image have a different metadata format, the ImageReaderService is not able to read it, and throws an error. This commit ensure that, in this case, the service return the original image instead of nothing
Resolves Meeds-io/meeds#2418
(cherry picked from commit 9e65276)