Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No image displayed when ImageResizeService throw an error - EXO-74337 #648

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

rdenarie
Copy link
Member

Before this fix, in some case, the ImageResizeService can throw an error. I add a unit test with a specifi jpeg image generating this error : the jpeg metadata have different format (EXIF, JFIF ...), and jdk default image reader only support EXIF and JFIF. When a jpeg image have a different metadata format, the ImageReaderService is not able to read it, and throws an error. This commit ensure that, in this case, the service return the original image instead of nothing

Resolves Meeds-io/meeds#2418

…74337

Before this fix, in some case, the ImageResizeService can throw an error.
I add a unit test with a specifi jpeg image generating this error : the jpeg metadata have different format (EXIF, JFIF ...), and jdk default image reader only support EXIF and JFIF. When a jpeg image have a different metadata format, the ImageReaderService is not able to read it, and throws an error.
This commit ensure that, in this case, the service return the original image instead of nothing

Resolves Meeds-io/meeds#2418
@rdenarie rdenarie enabled auto-merge (rebase) September 23, 2024 10:31
Copy link

sonarcloud bot commented Sep 23, 2024

@rdenarie rdenarie merged commit 446138c into develop Sep 23, 2024
4 checks passed
@rdenarie rdenarie deleted the fix/task-74337 branch September 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ImageResize] Some jpeg images have metadata not readable by JDK ImageReader
2 participants