Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix the copied format not being applied to the selected text in some CKEditor instances - EXO-73291 - Meeds-io/MIPs#129 #647

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

sofyenne
Copy link
Contributor

Prior to this change, the copied format was not applied to the selected text in some CKEditor instances. This issue was due to the mouseup event being attached to the editor document and not being detected. This change attaches the entire event to the editor's editable element, resolving the issue.

@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Sep 23, 2024
Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Member

@azayati azayati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofyenne sofyenne merged commit 57da600 into feature/experience Sep 23, 2024
7 checks passed
@sofyenne sofyenne deleted the Task/73291 branch September 23, 2024 16:50
exo-swf pushed a commit that referenced this pull request Sep 23, 2024
… some CKEditor instances - EXO-73291 - Meeds-io/MIPs#129 (#647)

Prior to this change, the copied format was not applied to the selected
text in some CKEditor instances. This issue was due to the mouseup event
being attached to the editor document and not being detected. This
change attaches the entire event to the editor's editable element,
resolving the issue.
azayati pushed a commit that referenced this pull request Sep 24, 2024
… some CKEditor instances - EXO-73291 - Meeds-io/MIPs#129 (#647)

Prior to this change, the copied format was not applied to the selected
text in some CKEditor instances. This issue was due to the mouseup event
being attached to the editor document and not being detected. This
change attaches the entire event to the editor's editable element,
resolving the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants