Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anchor disappear in notes app for accentuated chars - EXO-68365 - Meeds-io/meeds#1495 #573

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

Jihed525
Copy link
Contributor

Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents.

(cherry picked from commit c11f217)

…Meeds-io/meeds#1495

Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents.

(cherry picked from commit c11f217)
@Jihed525 Jihed525 self-assigned this Dec 26, 2023
@Jihed525 Jihed525 enabled auto-merge (squash) December 26, 2023 19:11
@github-actions github-actions bot added the partialCIBuild Perform Partial CI Build label Dec 26, 2023
Copy link

sonarcloud bot commented Dec 26, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)
2 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@Jihed525 Jihed525 merged commit beb3d26 into develop Dec 26, 2023
4 of 5 checks passed
@Jihed525 Jihed525 deleted the backportDEV-68365 branch December 26, 2023 19:51
exo-swf pushed a commit that referenced this pull request Dec 27, 2023
…Meeds-io/meeds#1495 (#573)

Before this change, when create or edit note, add some lines in the
body, select a text click on anchor icon in ckeditor, in Anchor Name
type text containing accents, save note and edit note, anchor containing
accentuated chars disappear. To resolve this problem, remove the
accentuted chars in the anchor name. After this change, anchors are well
displayed with name without accents.

(cherry picked from commit c11f217)
SaraBoutej pushed a commit that referenced this pull request Jan 4, 2024
…Meeds-io/meeds#1495 (#573)

Before this change, when create or edit note, add some lines in the
body, select a text click on anchor icon in ckeditor, in Anchor Name
type text containing accents, save note and edit note, anchor containing
accentuated chars disappear. To resolve this problem, remove the
accentuted chars in the anchor name. After this change, anchors are well
displayed with name without accents.

(cherry picked from commit c11f217)
SaraBoutej pushed a commit that referenced this pull request Jan 4, 2024
…Meeds-io/meeds#1495 (#573)

Before this change, when create or edit note, add some lines in the
body, select a text click on anchor icon in ckeditor, in Anchor Name
type text containing accents, save note and edit note, anchor containing
accentuated chars disappear. To resolve this problem, remove the
accentuted chars in the anchor name. After this change, anchors are well
displayed with name without accents.

(cherry picked from commit c11f217)
SaraBoutej pushed a commit that referenced this pull request Jan 4, 2024
…Meeds-io/meeds#1495 (#573)

Before this change, when create or edit note, add some lines in the
body, select a text click on anchor icon in ckeditor, in Anchor Name
type text containing accents, save note and edit note, anchor containing
accentuated chars disappear. To resolve this problem, remove the
accentuted chars in the anchor name. After this change, anchors are well
displayed with name without accents.

(cherry picked from commit c11f217)
SaraBoutej pushed a commit that referenced this pull request Jan 4, 2024
…Meeds-io/meeds#1495 (#573)

Before this change, when create or edit note, add some lines in the
body, select a text click on anchor icon in ckeditor, in Anchor Name
type text containing accents, save note and edit note, anchor containing
accentuated chars disappear. To resolve this problem, remove the
accentuted chars in the anchor name. After this change, anchors are well
displayed with name without accents.

(cherry picked from commit c11f217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partialCIBuild Perform Partial CI Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants