-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: anchor disappear in notes app for accentuated chars - EXO-68365 - Meeds-io/meeds#1495 #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Meeds-io/meeds#1495 Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
akhanfir
approved these changes
Dec 26, 2023
Quality Gate failedFailed conditions B Maintainability Rating on New Code (required ≥ A) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
exo-swf
pushed a commit
that referenced
this pull request
Dec 27, 2023
…Meeds-io/meeds#1495 (#573) Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
SaraBoutej
pushed a commit
that referenced
this pull request
Jan 4, 2024
…Meeds-io/meeds#1495 (#573) Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
SaraBoutej
pushed a commit
that referenced
this pull request
Jan 4, 2024
…Meeds-io/meeds#1495 (#573) Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
SaraBoutej
pushed a commit
that referenced
this pull request
Jan 4, 2024
…Meeds-io/meeds#1495 (#573) Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
SaraBoutej
pushed a commit
that referenced
this pull request
Jan 4, 2024
…Meeds-io/meeds#1495 (#573) Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents. (cherry picked from commit c11f217)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when create or edit note, add some lines in the body, select a text click on anchor icon in ckeditor, in Anchor Name type text containing accents, save note and edit note, anchor containing accentuated chars disappear. To resolve this problem, remove the accentuted chars in the anchor name. After this change, anchors are well displayed with name without accents.
(cherry picked from commit c11f217)