This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Bump extract-zip version #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bump allows for a future release of extract-zip, that in turn pulls in a newer future release of concat-stream to mitigate [a possible memory disclosure vulnerability](https://snyk.io/vuln/npm:concat-stream:20160901). extract-zip is already at 1.6.0 so this will not happen without this bump.
|
Could we please get this merged? |
|
Can we please get this merged to master? Change looks simple. |
|
👍 |
|
@nicks do you still work on this? |
|
This vulnerability doesn't affect us because we only download blessed binaries. To answer @erikvold 's broader question: at this point, it looks like there will be no further releases of PhantomJS (the upstream project). Thus, I basically consider this installer end-of-lifed. We would only do a release to patch major demonstrable problems. |
|
Seems that this is superseded by #732 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bump allows for a future release of extract-zip, that in turn pulls in a newer future release of concat-stream to mitigate a possible memory disclosure vulnerability. extract-zip is already at 1.6.0 so this will not happen without this bump.