Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 3.6] Move pkgconfig.sh to the framework #9889

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Jan 9, 2025

Description

Resolves Mbed-TLS/mbedtls-framework#101 for the mbedtls-3.6 branch.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because:
  • development PR provided # | not required because:
  • framework PR provided Move pkgconfig.sh to the framework mbedtls-framework#116
  • 3.6 PR provided # | not required because:
  • 2.28 PR provided # | not required because:
  • tests provided | not required because:

@valeriosetti valeriosetti changed the base branch from development to mbedtls-3.6 January 9, 2025 13:44
@valeriosetti valeriosetti self-assigned this Jan 9, 2025
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) and removed needs-ci Needs to pass CI tests labels Jan 9, 2025
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to update the framework pointer though.

Harry-Ramsey
Harry-Ramsey previously approved these changes Jan 13, 2025
Copy link
Contributor

@Harry-Ramsey Harry-Ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The following files are moved to the framework repo (deleted here):

tests/scripts/pkgconfig.sh

Signed-off-by: Valerio Setti <[email protected]>
Align component_test_cmake_as_package to the "development" branch
version.

Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti removed the needs-reviewer This PR needs someone to pick it up for review label Jan 14, 2025
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Harry-Ramsey Harry-Ramsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Jan 14, 2025
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 6f834e9 Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Development

Successfully merging this pull request may close these issues.

Move pkgconfig.sh to the framework
3 participants