Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defragment incoming TLS handshake messages #9872

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Defragment incoming TLS handshake messages #9872

wants to merge 1 commit into from
+113 −15

Conversation

rojer
Copy link
Contributor

@rojer rojer commented Dec 25, 2024 •
edited by mpg
Loading

Description

Defragment incoming TLS handshake messages.

Fixes #1840

PR checklist

  • changelog provided
  • development PR provided
  • framework PR not required
  • 3.6 PR provided #TODO
  • 2.28 PR not required because: in practice this mostly matters for TLS 1.3 which is not in 2.28
  • tests provided | not required because:

This was referenced Dec 25, 2024
Open
Open
@Neustradamus
Copy link

To follow this PR.

@Harry-Ramsey Harry-Ramsey added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 27, 2024
@mpg mpg requested review from mpg and waleed-elmelegy-arm January 2, 2025 09:31
@mpg mpg mentioned this pull request Jan 9, 2025
Open
@waleed-elmelegy-arm
Copy link
Contributor

Thanks @rojer for the PR. do you currently have the capacity to add automated tests?

@rojer
Copy link
Contributor Author

rojer commented Jan 9, 2025

Thanks @rojer for the PR. do you currently have the capacity to add automated tests?

not in the near future, unfortunately. holidays are over, and so is my free time.

@minosgalanakis minosgalanakis self-requested a review January 13, 2025 10:39
@mpg mpg removed their request for review January 13, 2025 10:39
@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waleed-elmelegy-arm waleed-elmelegy-arm Awaiting requested review from waleed-elmelegy-arm

@minosgalanakis minosgalanakis Awaiting requested review from minosgalanakis

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component-tls enhancement needs-review Every commit must be reviewed by at least two team members,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS Handshake record layer fragmentation not working
5 participants
@rojer @Neustradamus @waleed-elmelegy-arm @mpg @Harry-Ramsey