#181

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "umya-spreadsheet"
-version = "1.2.0"
+version = "1.2.1"
 authors = ["MathNya <[email protected]>"]
 repository = "https://github.com/MathNya/umya-spreadsheet"
 keywords = ["excel", "spreadsheet", "xlsx", "reader", "writer"]

README.md

@@ -37,7 +37,7 @@ assert_eq!("03-Feb-24", result);
 Add the following code to Cargo.toml
 ```toml
 [dependencies]
-umya-spreadsheet = "1.2.0"
+umya-spreadsheet = "1.2.1"
 ```
 Add the following code to main.rs
 ```rust

src/structs/columns.rs

@@ -81,7 +81,8 @@ impl Columns {
         offset_col_num: &u32,
     ) {
         self.get_column_collection_mut().retain(|x| {
-            !(x.get_col_num() > root_col_num && x.get_col_num() < &(root_col_num + offset_col_num))
+            !(x.get_col_num() >= root_col_num
+                && x.get_col_num() <= &(root_col_num + offset_col_num))
         });
         for column_dimension in self.get_column_collection_mut() {
             column_dimension.adjustment_remove_coordinate(root_col_num, offset_col_num);

src/structs/rows.rs

@@ -71,8 +71,9 @@ impl Rows {
         root_row_num: &u32,
         offset_row_num: &u32,
     ) {
-        self.get_row_dimensions_mut().retain(|k| {
-            !(k.get_row_num() > root_row_num && k.get_row_num() < &(root_row_num + offset_row_num))
+        self.get_row_dimensions_to_hashmap_mut().retain(|_, k| {
+            !(k.get_row_num() >= root_row_num
+                && k.get_row_num() <= &(root_row_num + offset_row_num))
         });
         for row_dimension in self.get_row_dimensions_mut() {
             row_dimension.adjustment_remove_coordinate(root_row_num, offset_row_num);

tests/integration_test.rs

@@ -1332,3 +1332,18 @@ fn issue_178() {
     let path = std::path::Path::new("./tests/result_files/issue_178.xlsx");
     let _ = umya_spreadsheet::writer::xlsx::write(&book, path);
 }
+
+#[test]
+fn issue_181() {
+    let path = std::path::Path::new("./tests/test_files/issue_181.xlsx");
+    let mut book = umya_spreadsheet::reader::xlsx::read(path).unwrap();
+    let mut sheet = book.get_sheet_by_name_mut("LOV").unwrap();
+    sheet.remove_row(&2, &1);
+    for (key, row) in sheet.get_row_dimensions_to_hashmap() {
+        assert_eq!(key, &1);
+        assert_eq!(row.get_row_num(), &1);
+        assert_eq!(row.get_height(), &35.0);
+    }
+    let path = std::path::Path::new("./tests/result_files/issue_181.xlsx");
+    let _ = umya_spreadsheet::writer::xlsx::write(&book, path);
+}