Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zoomable image viewer #134

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ dependencies {
implementation(libs.navreimagined)
implementation(libs.hcaptcha)
implementation(libs.shimmer)
implementation(libs.zooomable)

ksp(libs.materii.partial.ksp)
ksp(libs.materii.enumutil.ksp)
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/java/com/xinto/opencord/di/ViewModelModule.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.xinto.opencord.di

import androidx.lifecycle.SavedStateHandle
import com.xinto.opencord.ui.viewmodel.*
import org.koin.androidx.viewmodel.dsl.viewModel
import org.koin.androidx.viewmodel.dsl.viewModelOf
import org.koin.dsl.module

Expand All @@ -14,4 +16,6 @@ val viewModelModule = module {
viewModelOf(::MessageMenuViewModel)
viewModelOf(::MentionsViewModel)
viewModelOf(::ChatInputViewModel)
viewModelOf(::ImageViewerViewModel)
viewModel { (handle: SavedStateHandle) -> NavigationViewModel(handle) }
}
10 changes: 10 additions & 0 deletions app/src/main/java/com/xinto/opencord/manager/ActivityManager.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ package com.xinto.opencord.manager
import android.app.Activity
import android.content.Context
import android.content.Intent
import android.net.Uri
import kotlin.reflect.KClass

interface ActivityManager {
fun startActivity(activity: KClass<out Activity>, clearOld: Boolean = true)
fun openUrl(uri: Uri)
}

class ActivityManagerImpl(
Expand All @@ -24,4 +26,12 @@ class ActivityManagerImpl(

appContext.startActivity(intent)
}

override fun openUrl(uri: Uri) {
val intent = Intent(Intent.ACTION_VIEW)
.apply { data = uri }
.apply { flags = Intent.FLAG_ACTIVITY_NEW_TASK }

appContext.startActivity(intent)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@ package com.xinto.opencord.manager

import android.content.ClipData
import android.content.Context
import android.net.Uri
import androidx.core.content.getSystemService

interface ClipboardManager {
fun setText(text: String)
fun setLink(url: String)
}

class ClipboardManagerImpl(
Expand All @@ -19,8 +17,4 @@ class ClipboardManagerImpl(
override fun setText(text: String) {
clipboard.setPrimaryClip(ClipData.newPlainText(null, text))
}

override fun setLink(url: String) {
clipboard.setPrimaryClip(ClipData.newRawUri(null, Uri.parse(url)))
}
}
31 changes: 17 additions & 14 deletions app/src/main/java/com/xinto/opencord/ui/AppActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@ import androidx.core.view.WindowCompat
import com.xinto.opencord.db.database.CacheDatabase
import com.xinto.opencord.gateway.DiscordGateway
import com.xinto.opencord.ui.navigation.AppDestination
import com.xinto.opencord.ui.navigation.back
import com.xinto.opencord.ui.screens.ImageViewerScreen
import com.xinto.opencord.ui.screens.Settings
import com.xinto.opencord.ui.screens.home.HomeScreen
import com.xinto.opencord.ui.screens.mentions.MentionsScreen
import com.xinto.opencord.ui.screens.pins.PinsScreen
import com.xinto.opencord.ui.theme.OpenCordTheme
import com.xinto.opencord.ui.util.SystemBarsControl
import com.xinto.opencord.ui.viewmodel.NavigationViewModel
import dev.olshevski.navigation.reimagined.AnimatedNavHost
import dev.olshevski.navigation.reimagined.navigate
import dev.olshevski.navigation.reimagined.rememberNavController
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.MainScope
import kotlinx.coroutines.launch
import org.koin.android.ext.android.get
import org.koin.androidx.compose.getViewModel

class AppActivity : ComponentActivity() {
private val scope = MainScope()
Expand All @@ -52,16 +52,16 @@ class AppActivity : ComponentActivity() {
}

setContent {
val nav = rememberNavController<AppDestination>(startDestination = AppDestination.Main)

BackHandler { nav.back() }

OpenCordTheme {
SystemBarsControl()

val nav = getViewModel<NavigationViewModel>(extras = defaultViewModelCreationExtras)

BackHandler { nav.back() }

AnimatedNavHost(
controller = nav,
emptyBackstackPlaceholder = { nav.navigate(AppDestination.Main) },
backstack = nav.backstack,
emptyBackstackPlaceholder = { nav.resetToMain() },
transitionSpec = { _, _, to ->
if (to == AppDestination.Main) {
slideIntoContainer(
Expand All @@ -87,11 +87,6 @@ class AppActivity : ComponentActivity() {
modifier = Modifier
.fillMaxSize()
.imePadding(),
onPinsClick = { nav.navigate(AppDestination.Pins(data = it)) },
onSettingsClick = { nav.navigate(AppDestination.Settings) },
onMentionsClick = { nav.navigate(AppDestination.Mentions) },
onFriendsClick = { /* TODO */ },
onSearchClick = { /* TODO */ },
)

AppDestination.Settings -> Settings(
Expand All @@ -115,6 +110,14 @@ class AppActivity : ComponentActivity() {
.imePadding(),
onBackClick = { nav.back() },
)

is AppDestination.ImageViewer -> ImageViewerScreen(
data = dest.data,
onBackClick = { nav.back() },
modifier = Modifier
.fillMaxSize()
.imePadding(),
)
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
package com.xinto.opencord.ui.components.attachment

import androidx.compose.foundation.clickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.material3.MaterialTheme
import androidx.compose.runtime.Composable
import androidx.compose.runtime.remember
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import com.xinto.opencord.ui.components.OCImage
Expand All @@ -13,11 +16,17 @@ fun AttachmentPicture(
width: Int,
height: Int,
modifier: Modifier = Modifier,
onClick: (() -> Unit) = {},
) {
OCImage(
url = url,
size = OCSize(width, height),
modifier = modifier
.clip(MaterialTheme.shapes.small),
.clip(MaterialTheme.shapes.small)
.clickable(
indication = null,
interactionSource = remember { MutableInteractionSource() },
onClick = onClick,
),
)
}
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
package com.xinto.opencord.ui.navigation

import android.app.Activity
import android.os.Parcelable
import androidx.compose.runtime.Immutable
import com.xinto.opencord.ui.util.topDestination
import dev.olshevski.navigation.reimagined.NavController
import dev.olshevski.navigation.reimagined.pop
import dev.olshevski.navigation.reimagined.replaceAll
import kotlinx.parcelize.Parcelize

@Parcelize
Expand All @@ -22,6 +17,9 @@ sealed interface AppDestination : Parcelable {

@Parcelize
data class Pins(val data: PinsScreenData) : AppDestination

@Parcelize
data class ImageViewer(val data: ImageViewerData) : AppDestination
}

@Parcelize
Expand All @@ -30,15 +28,9 @@ data class PinsScreenData(
val channelId: Long,
) : Parcelable

context(Activity)
fun NavController<AppDestination>.back() {
val top = topDestination()

if (top == AppDestination.Main) {
finish()
} else if (backstack.entries.size > 1) {
pop()
} else {
replaceAll(AppDestination.Main)
}
}
@Parcelize
@Immutable
data class ImageViewerData(
val url: String,
val fileName: String? = null,
) : Parcelable
Loading