Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9 Create a Complete New Architecture #10

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

9 Create a Complete New Architecture #10

wants to merge 32 commits into from

Conversation

MasterLaplace
Copy link
Owner

@MasterLaplace MasterLaplace commented Oct 17, 2023 •
edited
Loading

@MasterLaplace MasterLaplace added documentation Improvements or additions to documentation enhancement New feature or request optimizing performance optimization feature labels Oct 17, 2023
@MasterLaplace MasterLaplace self-assigned this Oct 17, 2023
@MasterLaplace MasterLaplace linked an issue Oct 17, 2023 that may be closed by this pull request
Create a Complete New Architecture #9
Open
6 tasks
MasterLaplace and others added 12 commits October 17, 2023 05:51
@MasterLaplace
docs(.github): put the correct name of the project
50c93b5
@MasterLaplace
Merge pull request #14 from MasterLaplace/11-implement-github-setup
c8b4500 
docs(.github): put the correct name of the project
@MasterLaplace
refactor(LaplaceLib): improve lib_two_free, lib_two_print and add an …
6f01aed 
…fast flag in Libs's makefile
@MasterLaplace
Merge pull request #15 from MasterLaplace/12-implement-laplace-library
c54b2e2 
12 Implement Laplace Library
@MasterLaplace
style(src): improve style of Laplace Launcher
e157c6b
@MasterLaplace
Merge pull request #16 from MasterLaplace/13-implement-laplace-launcher
01fccd2 
13 Implement Laplace Launcher
@MasterLaplace
feat(Engine): build core file of the Engine
174a8f9
@MasterLaplace
feat(src): build with the engine version specified in the config file
a4b6c45
@MasterLaplace
Merge pull request #18 from MasterLaplace/17-implement-a-version-mana…
936571d 
…gement

17 Implement a Version Management
@MasterLaplace
feat(Engine): Clock, Window, Config, Math and Engine module implemented
e005197
@MasterLaplace
Merge pull request #20 from MasterLaplace/19-implement-engine-module
b66e267 
feat(Engine): Clock, Window, Config, Math and Engine module implemented
@MasterLaplace
style(root): fclean when make launcher is executed
b4a1296
@MasterLaplace MasterLaplace force-pushed the 9-create-a-complete-new-architecture branch from 667dbe7 to b4a1296 Compare October 18, 2023 03:17
MasterLaplace
MasterLaplace commented Oct 18, 2023
View reviewed changes
.github/FUNDING.md Outdated Show resolved Hide resolved
MasterLaplace
MasterLaplace commented Oct 18, 2023
View reviewed changes
.github/workflows/create-release.yml Outdated
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested

MasterLaplace
MasterLaplace commented Oct 18, 2023
View reviewed changes
.github/workflows/update_readme.yml Outdated
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested

MasterLaplace
MasterLaplace commented Oct 18, 2023
View reviewed changes
CHANGELOG.md Outdated
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be fill with the content of the Engine-3D version 0.1.0

@MasterLaplace MasterLaplace added the minor This is a minor feature (increment version) label Oct 19, 2023
@MasterLaplace MasterLaplace marked this pull request as draft October 19, 2023 16:17
@MasterLaplace MasterLaplace temporarily deployed to github-pages October 20, 2023 04:55 — with GitHub Pages Inactive
@MasterLaplace MasterLaplace temporarily deployed to github-pages October 20, 2023 04:58 — with GitHub Pages Inactive
@MasterLaplace MasterLaplace temporarily deployed to github-pages October 20, 2023 04:59 — with GitHub Pages Inactive
@MasterLaplace MasterLaplace temporarily deployed to github-pages October 20, 2023 05:18 — with GitHub Pages Inactive
@MasterLaplace MasterLaplace force-pushed the 9-create-a-complete-new-architecture branch from 85c95fb to 7b23dda Compare October 20, 2023 14:21
@MasterLaplace MasterLaplace force-pushed the 9-create-a-complete-new-architecture branch from a36c45f to 3be09a5 Compare October 22, 2023 15:07
@MasterLaplace MasterLaplace force-pushed the 9-create-a-complete-new-architecture branch from 3be09a5 to 7b23dda Compare October 22, 2023 15:50
Sigmanificient
Sigmanificient requested changes Nov 12, 2023
View reviewed changes
Engine/Engine/Event/event.c Show resolved Hide resolved
Engine/Engine/Math/Geometry/triangle.c Show resolved Hide resolved
Engine/Engine/Math/Geometry/triangle.c Show resolved Hide resolved
Engine/Engine/Math/Matrix/matrix.c
Comment on lines +13 to +23
matrix4f matrix4_f_mul(matrix4f m, matrix4f n)
{
matrix4f o = MATRIX4F_DEFAULT;

for (unsigned i = 0; i < 4; i++)
for (unsigned j = 0; j < 4; j++)
for (unsigned k = 0; k < 4; k++)
o.m[i][j] += m.m[i][k] * n.m[k][j];

return o;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are doing a lot of matrix computation, it may be worth taking a look at a faster algorithm, here is a nice resource

Engine/Engine/Math/Matrix/matrix.c Show resolved Hide resolved
Engine/core.c
int main(int ac, const char *av[]) {
#endif
// Initialize the game engine and its components.
if (ac != 2) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ac is undefined in windows context?

Libs/LaplaceLib/include/laplace_lib.h

#ifndef LAPLACE_LIB_H_
#define LAPLACE_LIB_H_
#define auto_clean __attribute__((cleanup(laplace_lib_free)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't auto_clean only supported by GCC?

Libs/LaplaceLib/include/laplace_lib_version.h
////////////////////////////////////////////////////////////
// Define the LAPLACE_LIB version string
////////////////////////////////////////////////////////////
#define LAPLACE_LIB_VERSION_STRING "1.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the glue operator to build the library version string

Suggested change
#define LAPLACE_LIB_VERSION_STRING "1.0.0"
#define CAT(x) #x
#define XCAT(x) CAT(x)
#define LAPLACE_LIB_VERSION_STR \
XCAT(LAPLACE_LIB_VERSION_MAJOR) \
"." XCAT(LAPLACE_LIB_VERSION_MINOR) \
"." XCAT(LAPLACE_LIB_VERSION_PATCH)

Libs/LaplaceLib/lib_openfile.c

inline int laplace_lib_open_file(char const *filepath, unsigned oflag)
{
int fd = open(filepath, oflag);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file descriptor should be checker prior to the access call

Libs/LaplaceLink/include/laplace_link.h
} link_t;

//* It creates a link with the object passed in parameter.
extern link_t *laplace_link_create(void *_new);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are they marked as external symbols?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sigmanificient Sigmanificient Sigmanificient requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MasterLaplace MasterLaplace

Labels
documentation Improvements or additions to documentation enhancement New feature or request minor This is a minor feature (increment version) optimizing performance optimization feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Complete New Architecture
3 participants
@MasterLaplace @Sigmanificient @Martin-Boucault-35