Add a command line flag to prevent writing 'deny_unknown_fields' #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
A server can add backwards compatible optional fields which will break the client if it fails when we parse a response because we deny unknown fields.
Solution: Rather than remove that altogether (I assume you put it in for a good reason), I added a command line flag to prevent writing
deny_unknown_fields
to files. Plumbed this through in a more general 'options' field so further fields can be added without changing signatures in the future, or adding a large number of arguments to functions.Without flag
With flag: