Test with localstack #58
Conversation
Improve localstack
Improve localstack
|
@samuelpcabral Can we have these tests running in Gtihub actions? That would be great |
|
@MummanaSubramanya Sure.. I have been working on this today.. I am still making some improvements. Right after this PR is approved I will send the GitHub actions code 😁 |
There was a problem hiding this comment.
When trying to get things set up with this script, I'm seeing this set of error messages when everything else seem to come up successfully:
An error occurred (InternalFailure) when calling the CreateLogGroup operation: Service 'logs' is not enabled. Please check your 'SERVICES' configuration variable.
An error occurred (InternalFailure) when calling the CreateLogStream operation: Service 'logs' is not enabled. Please check your 'SERVICES' configuration variable.
What am I missing? Is the SERVICES configuration described in a README or CONTRIBUTING file?
This affects the Cloudwatch tests so I won't include this same comment there.
There was a problem hiding this comment.
Hi @paguilera I include the logs in the secondo push that I sent in the branch... is the line 10 in docker-compose.yml, check if you have: "- SERVICES=s3,lambda,dynamodb,rds,sqs,logs"
There was a problem hiding this comment.
These tests are failing for me locally with this error message for all tests:
ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the PutItem operation: Cannot do operations on a non-existent table
There was a problem hiding this comment.
This is because the localstack/docker-compose.yml reads the localstack/init-aws.sh,, check if you have the latest version of init-aws.sh.. should have the creation of two tables with command "awslocal dynamodb create-table"
There was a problem hiding this comment.
Is there any additional configuration that's needed for the logs services? See my comment for init-aws.sh for more info.
|
Hi @paguilera The error seems strange to me, it seems like you have some things updated and others no, because I made two different pushes to the branch... let me do the push with github actions and make sure everything is up to date... I will send another message when is done.. |
GitHub actions
|
PR moved to #59 |
Hello @paguilera I want to send now this merge without create the new version because with this new changes we can test the library locally... so will be much easy for everyone who wants to collaborate.
My idea is create the local tests for dynamo and cloudwatch, then create and release the version 1.0.0