Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conditional text color for partial marks in marks_panel.jsx #6483

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidlin2k
Copy link

@davidlin2k davidlin2k commented Feb 23, 2023

Motivation and Context

This feature enables users to easily identify partial marks in an assignment and provides a better visual representation for users to interpret their feedback.

Your Changes

Description: Added an additional conditional red-text class for mark

Type of change (select all that apply):

  • New feature (non-breaking change which adds functionality)

Testing

It's a front-end change and does not affect existing functionalities. Tested through the web interface on A1.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@davidlin2k davidlin2k marked this pull request as ready for review February 23, 2023 23:05
@david-yz-liu
Copy link
Contributor

Thank you @davidlin2k! I definitely see the motivation behind this PR. I'll need some time to think about what we want the UI to look like, and I'll keep you posted on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants