Added documentations for map-change event, zoomTo(), and extents #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliyanH
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Looking good! @yushan-mu please also add the fr documentation as well.
AliyanH
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Everything looks great! Could you please update the following example for layer, extent, and feature documentation page (both en & fr)? It will help make it consistent with other examples. Thanks!
It can be merged after these changes and once the map-change PR on Mapml.js is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Maps4HTML/MapML.js#907