Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add en and fr as (the only) languages that can be selected via lang attribute on <mapml-viewer> or ancestors #999

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add en and fr as (the only) languages that can be selected via lang attribute on <mapml-viewer> or ancestors #999

merged 1 commit into from
Oct 30, 2024

Conversation

prushforth
Copy link
Member

@prushforth prushforth commented Oct 17, 2024 •
edited
Loading

  • ancestors are light DOM only, for now. tbd if want to search across shadow boundaries.
  • Initial commit (no tests, most popup stuff not localized yet)
  • other languages omitted (for now) since translated strings are loaded at page load via the bundle, which is too costly

Closes #994

@yushan-mu yushan-mu mentioned this pull request Oct 22, 2024
Merged
@prushforth
Add en and fr as (the only) languages that can be
130af1f 
selected via lang attribute on <mapml-viewer> or
ancestors

Add grunt plugin to generate locale, localeFr keys for DefaultMapOptions.js

Add postintall for playwright, remove from gh action setup.
@prushforth prushforth merged commit 56a8791 into Maps4HTML:main Oct 30, 2024
1 check passed
@yushan-mu yushan-mu mentioned this pull request Nov 6, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider prototype support for the global lang attribute on <mapml-viewer>
1 participant
@prushforth