Add updated Brackets icon #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added updated Brackets icon to better follow the Human Interface Guidelines.
Added updated Brackets icon to better follow the Human Interface Guidelines.
Added updated Brackets icon to better follow the Human Interface Guidelines.
Added updated Brackets icon to better follow the Human Interface Guidelines.
Added updated Brackets icon to better follow the Human Interface Guidelines.
Added updated Brackets icon to better follow the Human Interface Guidelines.
|
Thanks for your pull request which is a great first contribution! Your new icon looks much better indeed, but it'd be great if you could fix two problems I came across, so I can add them to elementary+. The positioning of the 128px icon is a bit off as the baseline is too high when I compare your icon with for example the Terminal icon on the elementary HIG but also our current Foxit Reader icon. Also the 32px icon looks slightly too big: Terminal, Foxit Reader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updated Brackets icon to better follow the Human Interface Guidelines.
The previous icons, though did resemble elementary OS's style, didn't completely follow the guidelines they're based on. I did my best to fix that (in all six sizes).
Above is a clear comparison between the original and the modified version (64x64), and here's a screenshot of the slingshot + plank integration.