Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer extension storage #89

Open
wants to merge 4 commits into
base: signer_extension
Choose a base branch
from
Open

Signer extension storage #89

wants to merge 4 commits into from

Conversation

Apokalip
Copy link
Contributor

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@Apokalip Apokalip self-assigned this Feb 23, 2023
@Apokalip Apokalip changed the base branch from main to signer_extension February 27, 2023 14:38
@Apokalip Apokalip requested review from SupremoUGH and DanielZhangReal and removed request for SupremoUGH February 27, 2023 14:44
DanielZhangReal
DanielZhangReal reviewed Feb 27, 2023
View reviewed changes
manta-js/package/src/privateWallet.ts
async updateStorage(): Promise<boolean> {
try {
await this.waitForWallet();
this.walletIsBusy = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think storing utxos to storage should be asynchronous, it should not block user interaction. even if storage fails

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be fine since we are just reading the signer storage. Will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangReal DanielZhangReal DanielZhangReal left review comments

@SupremoUGH SupremoUGH Awaiting requested review from SupremoUGH

@bhgomes bhgomes Awaiting requested review from bhgomes

@vern-manta vern-manta Awaiting requested review from vern-manta

At least 2 approving reviews are required to merge this pull request.

Assignees

@Apokalip Apokalip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apokalip @DanielZhangReal