-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft #1
Merged
Merged
first draft #1
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b175877
first draft
mschwoer 7e7a8c0
first draft
mschwoer 4762201
first draft
mschwoer b9e1cfc
first draft
mschwoer ea602a0
first draft
mschwoer f3d27ce
first draft
mschwoer 238aa60
first draft
mschwoer b9ac6f0
first draft
mschwoer 6ae9f05
first draft
mschwoer 4b957ae
first draft
mschwoer 39ce220
first draft
mschwoer ff09db1
first draft
mschwoer e083a82
first draft
mschwoer 0416da5
turn it into an action
mschwoer 2d93979
turn it into an action
mschwoer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
name: 'Code Review' | ||
description: 'Generate prompt for code review' | ||
#inputs: | ||
# who-to-greet: # id of input | ||
# description: 'Who to greet' | ||
# required: true | ||
# default: 'World' | ||
#outputs: | ||
# random-number: | ||
# description: "Random number" | ||
# value: ${{ steps.random-number-generator.outputs.random-number }} | ||
runs: | ||
using: "composite" | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Get changed files | ||
id: changed-files | ||
uses: tj-actions/changed-files@v44 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Install dependencies | ||
shell: bash | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install PyGithub # requests | ||
|
||
- name: Run Code Review | ||
env: | ||
# REVIEW_API_URL: some_url #${{ secrets.REVIEW_API_URL }} | ||
# REVIEW_API_KEY: some_api_ket #${{ secrets.REVIEW_API_KEY }} | ||
PR_NUMBER: ${{ github.event.number }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
shell: bash | ||
run: | | ||
python code_review.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
import os | ||
# import requests | ||
# import subprocess | ||
from github import Github | ||
|
||
g = Github(os.environ['GITHUB_TOKEN']) | ||
repo = g.get_repo(os.environ['GITHUB_REPOSITORY']) | ||
pr = repo.get_pull(int(os.environ['PR_NUMBER'])) | ||
|
||
|
||
def get_file_content(file_path, commit_sha): | ||
try: | ||
return repo.get_contents(file_path, ref=commit_sha).decoded_content.decode() | ||
except: | ||
return "" # Return empty string if file doesn't exist in that commit | ||
|
||
|
||
def get_file_patch(file): | ||
return file.patch if file.patch else "" | ||
|
||
|
||
changed_files = '${{ steps.changed-files.outputs.all_changed_files }}'.split() | ||
|
||
file_data = [] | ||
for file in pr.get_files(): | ||
if file.filename in changed_files: | ||
original_content = get_file_content(file.filename, pr.base.sha) | ||
changed_content = get_file_content(file.filename, pr.head.sha) | ||
patch = get_file_patch(file) | ||
file_data.append({ | ||
"filename": file.filename, | ||
"originalContent": original_content, | ||
"changedContent": changed_content, | ||
"patch": patch | ||
}) | ||
|
||
changed_files = '${{ steps.changed-files.outputs.all_changed_files }}'.split() | ||
print("XXX", changed_files) | ||
|
||
|
||
def format_code_review_data(data_list): | ||
formatted_string = "Beginning of Code Review Data:\n\n" | ||
|
||
for item in data_list: | ||
formatted_string += f"=============\n" | ||
formatted_string += f"Beginning of data for file: {item['filename']}\n" | ||
formatted_string += "Original Content:\n" | ||
formatted_string += "```\n" | ||
formatted_string += item['originalContent'] | ||
formatted_string += "\n```\n\n" | ||
formatted_string += "Patch:\n" | ||
formatted_string += "```\n" | ||
formatted_string += item['patch'] | ||
formatted_string += "\n```\n\n" | ||
formatted_string += "---\n" | ||
formatted_string += f"End of data for file: {item['filename']}\n" | ||
formatted_string += f"=============\n\n" | ||
|
||
formatted_string += "End of Code Review Data" | ||
|
||
return formatted_string | ||
|
||
|
||
print("# ##############################################################################") | ||
print(format_code_review_data(file_data)) | ||
print("# ##############################################################################") | ||
|
||
try: | ||
review_comments = {file: [(1, 'cool')] for file in changed_files} | ||
g = Github(os.environ['GITHUB_TOKEN']) | ||
repo = g.get_repo(os.environ['GITHUB_REPOSITORY']) | ||
pr = repo.get_pull(int(os.environ['PR_NUMBER'])) | ||
|
||
last_commit = list(pr.get_commits())[-1] | ||
|
||
for filename, comments in review_comments.items(): | ||
for line, comment in comments: | ||
print("XXX", line, comment) | ||
pr.create_review_comment(body=comment, commit=last_commit, path=filename, line=int(line)) | ||
|
||
print('Code review completed and comments posted.') | ||
except Exception as e: | ||
print(f'Error during code review: {str(e)}') | ||
import traceback | ||
|
||
traceback.print_exc() | ||
exit(1) | ||
shell: python | ||
# response = requests.post( | ||
# os.environ['REVIEW_API_URL'], | ||
# json={"files": file_data}, | ||
# headers={ | ||
# 'Authorization': f"Bearer {os.environ['REVIEW_API_KEY']}", | ||
# 'Content-Type': 'application/json' | ||
# } | ||
# ) | ||
# response.raise_for_status() | ||
# review_comments = response.json() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
name: Code Review | ||
name: Code Review | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool |
||
|
||
on: | ||
pull_request: | ||
|
@@ -7,8 +7,122 @@ on: | |
jobs: | ||
code-review: | ||
runs-on: ubuntu-latest | ||
#if: contains(github.event.pull_request.labels.*.name, 'review') | ||
if: contains(github.event.pull_request.labels.*.name, 'code-review') | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Get changed files | ||
id: changed-files | ||
uses: tj-actions/changed-files@v44 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.11' | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install requests PyGithub | ||
|
||
- name: Run Code Review | ||
env: | ||
REVIEW_API_URL: some_url #${{ secrets.REVIEW_API_URL }} | ||
REVIEW_API_KEY: some_api_ket #${{ secrets.REVIEW_API_KEY }} | ||
PR_NUMBER: ${{ github.event.number }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
run: | | ||
import os | ||
import requests | ||
import subprocess | ||
from github import Github | ||
|
||
g = Github(os.environ['GITHUB_TOKEN']) | ||
repo = g.get_repo(os.environ['GITHUB_REPOSITORY']) | ||
pr = repo.get_pull(int(os.environ['PR_NUMBER'])) | ||
|
||
def get_file_content(file_path, commit_sha): | ||
try: | ||
return repo.get_contents(file_path, ref=commit_sha).decoded_content.decode() | ||
except: | ||
return "" # Return empty string if file doesn't exist in that commit | ||
|
||
def get_file_patch(file): | ||
return file.patch if file.patch else "" | ||
|
||
changed_files = '${{ steps.changed-files.outputs.all_changed_files }}'.split() | ||
|
||
file_data = [] | ||
for file in pr.get_files(): | ||
if file.filename in changed_files: | ||
original_content = get_file_content(file.filename, pr.base.sha) | ||
changed_content = get_file_content(file.filename, pr.head.sha) | ||
patch = get_file_patch(file) | ||
file_data.append({ | ||
"filename": file.filename, | ||
"originalContent": original_content, | ||
"changedContent": changed_content, | ||
"patch": patch | ||
}) | ||
|
||
changed_files = '${{ steps.changed-files.outputs.all_changed_files }}'.split() | ||
print("XXX", changed_files) | ||
|
||
def format_code_review_data(data_list): | ||
formatted_string = "Beginning of Code Review Data:\n\n" | ||
|
||
for item in data_list: | ||
formatted_string += f"=============\n" | ||
formatted_string += f"Beginning of data for file: {item['filename']}\n" | ||
formatted_string += "Original Content:\n" | ||
formatted_string += "```\n" | ||
formatted_string += item['originalContent'] | ||
formatted_string += "\n```\n\n" | ||
formatted_string += "Patch:\n" | ||
formatted_string += "```\n" | ||
formatted_string += item['patch'] | ||
formatted_string += "\n```\n\n" | ||
formatted_string += "---\n" | ||
formatted_string += f"End of data for file: {item['filename']}\n" | ||
formatted_string += f"=============\n\n" | ||
|
||
formatted_string += "End of Code Review Data" | ||
|
||
return formatted_string | ||
|
||
print("# ##############################################################################") | ||
print(format_code_review_data(file_data)) | ||
print("# ##############################################################################") | ||
|
||
try: | ||
review_comments = { file:[(1,'cool')] for file in changed_files } | ||
g = Github(os.environ['GITHUB_TOKEN']) | ||
repo = g.get_repo(os.environ['GITHUB_REPOSITORY']) | ||
pr = repo.get_pull(int(os.environ['PR_NUMBER'])) | ||
|
||
last_commit = list(pr.get_commits())[-1] | ||
|
||
for filename, comments in review_comments.items(): | ||
for line, comment in comments: | ||
print("XXX", line, comment) | ||
pr.create_review_comment(body=comment, commit=last_commit, path=filename, line=int(line)) | ||
|
||
print('Code review completed and comments posted.') | ||
except Exception as e: | ||
print(f'Error during code review: {str(e)}') | ||
import traceback | ||
traceback.print_exc() | ||
exit(1) | ||
shell: python | ||
# response = requests.post( | ||
# os.environ['REVIEW_API_URL'], | ||
# json={"files": file_data}, | ||
# headers={ | ||
# 'Authorization': f"Bearer {os.environ['REVIEW_API_KEY']}", | ||
# 'Content-Type': 'application/json' | ||
# } | ||
# ) | ||
# response.raise_for_status() | ||
# review_comments = response.json() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool