Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multicova #347

Open
wants to merge 195 commits into
base: development
Choose a base branch
from
Open

Enable multicova #347

wants to merge 195 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Oct 8, 2024

re-active multicova backend, which was disabled here https://github.com/MannLabs/alphapeptstats/pull/329/files

@mschwoer mschwoer requested a review from JuliaS92 October 8, 2024 12:58
# plotly doesnt allow to assign color to certain group
# update instead the figure in form of a dict
# color_dict with group_variable/legendgroup as key, and corresponding color as value
# TODO revisit this comment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://plotly.com/python-api-reference/generated/generated/plotly.graph_objects.Figure.update_traces.html + selector to set individual color or something like:
plot.for_each_trace(lambda t: t.update(marker_color=color_dict.get(t.legendgroup))

Copy link
Collaborator

@JuliaS92 JuliaS92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the analysis actually available in the UI?

# Conflicts:
#	alphastats/DataSet_Statistics.py
#	alphastats/statistics/MultiCovaAnalysis.py
#	alphastats/statistics/StatisticUtils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants