Add rt length to output ii #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
commented
Nov 13, 2024
nbs/tutorial_nbs/logging.ipynb
Outdated
| @@ -21,11 +21,11 @@ | |||
| "name": "stderr", | |||
| "output_type": "stream", | |||
| "text": [ | |||
| "0:00:00.000142 \u001b[32;20mPROGRESS: test\u001b[0m\n", | |||
| "0:00:00.000142 \u001B[32;20mPROGRESS: test\u001B[0m\n", | |||
There was a problem hiding this comment.
not sure what this was?
GeorgWa
approved these changes
Nov 14, 2024
alphadia/outputtransform.py
Outdated
| base_dict[f"{prefix}rt_limit_min"] = stats["rt_limit_min"] | ||
| base_dict[f"{prefix}rt_limit_max"] = stats["rt_limit_max"] | ||
|
|
||
| base_dict[f"{prefix}rt_duration_sec"] = stats["rt_duration_sec"] |
There was a problem hiding this comment.
I actually agree with Feng that we should convert the values to minutes. We can store them as minutes from the beginning.
| verbosity="error", | ||
| ) | ||
| # Log the full traceback | ||
| if self.path is None: |
There was a problem hiding this comment.
Thanks for the refactor 😄
|
|
||
| self._config: Config = config | ||
|
|
||
| # deliberately not saving the actual raw data here to avoid the saved manager file being too large |
There was a problem hiding this comment.
This is just a comment why the dia_data goes back into PeptideCentric and doesn't stay here as one might expect?
nbs/tutorial_nbs/logging.ipynb
Outdated
| @@ -21,11 +21,11 @@ | |||
| "name": "stderr", | |||
| "output_type": "stream", | |||
| "text": [ | |||
| "0:00:00.000142 \u001b[32;20mPROGRESS: test\u001b[0m\n", | |||
| "0:00:00.000142 \u001B[32;20mPROGRESS: test\u001B[0m\n", | |||
There was a problem hiding this comment.
We have colored logging. I don't know why but it looks like your machine likes a different ANSI escape than mine???
mschwoer
force-pushed
the
add_rt_length_to_output_II
branch
from
6a8b717
to
576730b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First guess at what should be added in terms of raw file stats.
Also some renamings and refactoring of the pickle code.
cf. also #368