Rename progress folder #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgWa
approved these changes
Nov 14, 2024
| @@ -380,7 +382,7 @@ def run(*args, **kwargs): | |||
| library_path=library_path, | |||
| fasta_path_list=fasta_path_list, | |||
| config=config, | |||
| custom_quant_dir=custom_quant_dir, | |||
| quant_path=quant_dir, | |||
There was a problem hiding this comment.
can't we call both of them quant_dir for simplicity?
There was a problem hiding this comment.
"_path" is more correct and should be used throughout the code base (cf. also the # TODO rename all output_directory, output_folder => output_path, quant_dir->quant_path (except cli parameter))
imho it's fine to name the cli parameter quant-dir as this might be more familiar to users .. very early on this should be called quant_path then
mschwoer
force-pushed
the
rename_progress_folder
branch
from
ab81033
to
06aa489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.progressfolder toquantcustom-quant-dirtoquant-dir