Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-5573 Fix schedule object using incorrect time format #101

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

MertCingoz
Copy link
Member

Addressing scheduling issues discussed in #98

@terrypacker
Copy link

@MertCingoz I'd like to discuss this in person so lets setup some time this week.

Copy link

@terrypacker terrypacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation in the meeting, looks good.

@MertCingoz MertCingoz merged commit 480ef1d into master Jul 24, 2024
@MertCingoz MertCingoz deleted the fix/RAD-5573/scheduling-2 branch July 24, 2024 14:56
@kishorevenki
Copy link

@MertCingoz , @terrypacker
I am not able to test the Schedule Object because of the test dependency with TimeSynchronization Service.

  • When TimeSynch service is received from other device , the local device should update its clock and set the Local-Date & Local-Time property of the Device Object accordingly.
  • Even the TimeSynch Test is incorrect because the test merely compares the dateTime received instead the test should compare the localDate and LocalTime properties of the LocalDevice Object.

Please advise whether should I create a new ticket for TimeSynch service.

Thanks.

@MertCingoz MertCingoz linked an issue Jul 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schedule Object can not valid
3 participants