Reject invalid script_payload credential_fields #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mapping credentials ensure that only valid credential fields are used.
agrare
force-pushed
the
reject_invalid_configuration_script_payload_credentials_credential_field
branch
from
9b5b98d
to
8f1509b
Compare
|
Checked commit agrare@8f1509b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
agrare
commented
Sep 25, 2023
| credential_ref, credential_field = ref.values_at("credential_ref", "credential_field") | ||
|
|
||
| credential_class = credentials_by_ems_ref[credential_ref].class | ||
| allowed_credential_fields = defined?(credential_class::API_ATTRIBUTES) ? credential_class::API_ATTRIBUTES.pluck(:id) : [] |
There was a problem hiding this comment.
credential_class::API_ATTRIBUTES.pluck(:id) - This seems like something we could expose in core
agrare
deleted the
reject_invalid_configuration_script_payload_credentials_credential_field
branch
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Sep 27, 2023
…ipt_payload_credentials_credential_field Reject invalid script_payload credential_fields (cherry picked from commit dfca21a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping credentials ensure that only valid credential fields are used.
Ref: ManageIQ/manageiq-ui-classic#8905 (review)