[v4.1.z] Don't try creating methods for /processedtemplates pseudo-entity #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Openshift discovery lists both `templates` and `processedtemplates` for same kind "Template": openshift/origin#21668 `templates` is a regular stored api object. `processedtemplates` endpoint isn't a stored object, its POST is a special input (template + params) -> output function. That functionality is already covered in kubeclient by `process_template` method. It doesn't need regular create_, get_, watch_ etc methods. This is already so because in all openshift versions, `templates` comes after `processedtemplates` and replaces it in `@entities["template"]`.
masayag
approved these changes
Dec 17, 2018
grosser
approved these changes
Dec 17, 2018
This was referenced Dec 17, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small followup for #366, only relevant for openshift.
This changes nothing but achieves the desired result deliberates instead of accidentally :-) 😅
Openshift discovery lists both
templatesandprocessedtemplatespaths for same kind "Template": openshift/origin#21668templatesis a regular stored api object. We wantcreate_template,watch_templatesetc. methods to access this endpoint.processedtemplatesendpoint isn't a stored object, its POST is a special input (template + params) -> output function. That functionality is already covered in kubeclient byprocess_templatemethod. It doesn't need regularcreate_,get_etc methods.Before 4.1.0,
processedtemplateswas discarded inparse_definitionas it didn't match the singular kind.AFAICT it's still not a problem because first we collect
@entitieshash keyed by singular name, and all openshift discovery data,templatescomes afterprocessedtemplatesand replaces it in@entities["template"]. So noprocessedtemplatesmethods were defined 😆Anyway, this patch avoids the collision by explicitly skipping
processedtemplates.@masayag @grosser please review