Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[1LP][WIP] Automate Ansible non-ascii Hostname test. #9925

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[1LP][WIP] Automate Ansible non-ascii Hostname test. #9925

wants to merge 2 commits into from

Conversation

sbulage
Copy link
Contributor

@sbulage sbulage commented Feb 17, 2020 •
edited by digitronik
Loading

Purpose or Intent

  • Order Ansible service with Non-ASCII character hostname.

PRT Run

{{pytest: cfme/tests/ansible/test_embedded_ansible_services.py -k "test_service_ansible_playbook_order_non_ascii" --long-running -svvvv }}

@sbulage
Copy link
Contributor Author

sbulage commented Feb 17, 2020

Depends on #9660

@sbulage sbulage changed the title [WIP] Automate Ansible non-ascii Hostname test. [WIPTEST] Automate Ansible non-ascii Hostname test. Feb 19, 2020
@sbulage sbulage changed the title [WIPTEST] Automate Ansible non-ascii Hostname test. [RFR] Automate Ansible non-ascii Hostname test. Feb 19, 2020
sshveta
sshveta suggested changes Feb 20, 2020
View reviewed changes
cfme/tests/ansible/test_embedded_ansible_services.py
# Non-ASCII hostname element name.
hostname = fauxfactory.gen_alphanumeric(start="àcon_")
view.fields(ele_name).fill(hostname)
time.sleep(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use wait_for(lambda: not view.submit_button.disabled, timeout=7) instead of time.sleep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submit button is enabled in the UI. I have tried all possibilities with wait_for and end up time.sleep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9660 (comment)

@sshveta sshveta changed the title [RFR] Automate Ansible non-ascii Hostname test. [WIPTEST] Automate Ansible non-ascii Hostname test. Feb 20, 2020
@sbulage sbulage changed the title [WIPTEST] Automate Ansible non-ascii Hostname test. [RFR] Automate Ansible non-ascii Hostname test. Feb 24, 2020
@sbulage
Copy link
Contributor Author

sbulage commented Feb 24, 2020

Service Dialog value is require to update Hostname after filling up, but it will not get reflected for service. We require wait for at least 5 seconds.
I have tried all possible conditions in wait_for, and end up with time.sleep.

@ganeshhubale ganeshhubale added the test-automation To be applied on PR's which are automating existing manual cases label Feb 24, 2020
@ganeshhubale ganeshhubale changed the title [RFR] Automate Ansible non-ascii Hostname test. [WIPTEST] Automate Ansible non-ascii Hostname test. Feb 24, 2020
@sshveta sshveta changed the title [WIPTEST] Automate Ansible non-ascii Hostname test. [1LP][RFR] Automate Ansible non-ascii Hostname test. Feb 24, 2020
@digitronik
Copy link
Contributor

@sbulage I think you are running the wrong test on PRT ^^

@digitronik digitronik self-assigned this Feb 27, 2020
@digitronik
Copy link
Contributor

@sbulage started run for test_service_ansible_playbook_order_non_ascii in state of test_service_ansible_service_name

@sbulage
Copy link
Contributor Author

sbulage commented Feb 28, 2020

@sbulage started run for test_service_ansible_playbook_order_non_ascii in state of test_service_ansible_service_name

@digitronik I have seen PRT, it is using test_service_ansible_playbook_order_non_ascii.

@jawatts jawatts assigned jawatts and unassigned digitronik Feb 28, 2020
@jawatts
Copy link
Contributor

jawatts commented Feb 28, 2020

@sbulage PRT is failing, can you take a look? Or whoever is taking your FA

@jawatts jawatts changed the title [1LP][RFR] Automate Ansible non-ascii Hostname test. [1LP][WIPTEST] Automate Ansible non-ascii Hostname test. Feb 28, 2020
@digitronik
Copy link
Contributor

@sbulage started run for test_service_ansible_playbook_order_non_ascii in state of test_service_ansible_service_name

@digitronik I have seen PRT, it is using test_service_ansible_playbook_order_non_ascii.

I edited your pytest run.
old run: http://infra-trackerbot2.cfme2.lab.eng.rdu2.redhat.com/pr/run/1047

@dajoRH dajoRH changed the title [1LP][WIPTEST] Automate Ansible non-ascii Hostname test. [1LP][WIP] Automate Ansible non-ascii Hostname test. Mar 5, 2020
@dajoRH
Copy link
Contributor

dajoRH commented Mar 5, 2020

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

@dajoRH dajoRH added WIP and removed WIP-testing labels Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshhubale ganeshhubale ganeshhubale requested changes

@sshveta sshveta sshveta approved these changes

@jawatts jawatts jawatts approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@jawatts jawatts

Labels
lint-ok needs-rebase test-automation To be applied on PR's which are automating existing manual cases WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sbulage @digitronik @jawatts @dajoRH @sshveta @ganeshhubale