Avoid prefixing :export for css modules #25
Conversation
Avoid prefix for :export since :export block defines the symbols that are going to be exported to the consumer. It can be thought of functionally equivalent to the module.export
|
This was causing issues with export since it was prefixing |
| // that are going to be exported to the consumer | ||
| if (selector.indexOf(":export") !== -1) { | ||
| return selector; | ||
| } |
There was a problem hiding this comment.
Seems fine to me. But let's add a test for this case so we don't regress on this in the future.
|
Thanks for the contribution @michelfrf. Looking good so far 🌵 |
|
The test was added let me know if you are happy with the changes. |
| // Avoid prefix for :exports since :export block defines the symbols | ||
| // that are going to be exported to the consumer |
There was a problem hiding this comment.
| // Avoid prefix for :exports since :export block defines the symbols | |
| // that are going to be exported to the consumer | |
| // Avoid prefix for `:export` blocks because they define the symbols | |
| // that are going to be exported to the consumer, | |
| // https://github.com/css-modules/icss#export |
| [id="foo"] { | ||
| background: #f00; | ||
| } | ||
|
|
||
| [id^="bar"] { | ||
| background: #0f0; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we can assert the same functionality with just the .foo and :export rules or maybe just :export by itself
| [id="foo"] { | |
| background: #f00; | |
| } | |
| [id^="bar"] { | |
| background: #0f0; | |
| } |
| @@ -119,4 +119,8 @@ describe('postcss-increase-specificity', function() { | |||
| it('should not change the descendant rules of @keyframes', function() { | |||
| return testPlugin('./test/fixtures/keyframes.css', './test/fixtures/keyframes.expected.css'); | |||
| }); | |||
|
|
|||
| it('should ignore :export option used in scss files', function() { | |||
| return testPlugin('./test/fixtures/scss/export-option.scss', './test/fixtures/scss/export-option.expected.scss'); | |||
There was a problem hiding this comment.
I don't think we need to use the scss extension here. CSS modules seem like they also applies to .css
Avoid prefix for
:exportsince:exportblock defines the symbols that are going to be exported to the consumer. It can be thought of functionally equivalent to the module.export