Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complexes pr 3 #3526

Open
wants to merge 32 commits into
base: development
Choose a base branch
from

Conversation

mikestillman
Copy link
Member

This pull request includes the next set of minor package changes to get them working with Complexes (the current plan is to make this the default in the April 2025 M2 release, removing the old ChainComplex type from the Core).

Pinged authors: do these changes look ok to you? (They should all be minor: changing ChainComplex to Complex, etc)

After this pull request, there are not too many packages left to transfer to work directly with the new Complexes package.

mikestillman and others added 21 commits October 7, 2024 16:42
…lexes. Also discovered: Complexes doesn't play well with rings with degree length 0.
…s (added new optional argument to minimalBettiNumbers)
…es (added new optional argument to minimalBettiNumbers and bassNumbers)
…. Also removed definition of global symbol 'Range'
@@ -27,7 +27,7 @@ newPackage(
Headline => "routines for working with normal toric varieties and related objects",
Keywords => {"Toric Geometry"},
PackageExports => {"Polyhedra", "Schubert2", "Varieties","Truncations"},
PackageImports => {"FourierMotzkin", "LLLBases"},
PackageImports => {"FourierMotzkin","Normaliz","LLLBases","Complexes"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NormalToricVarieties doesn't use Normaliz.

@bbarwick
Copy link

@mikestillman (cc: @bstone) The QuillenSuslin.m2 changes look good to me. Thanks!

…One test fails, due to another package not yet changed to work with Complexes.
…ing with Complexes. Potentially subtle change involving mapping cone, which now orders the summands differently
…ionResolutions to get them working with the new Complexes package
…. Needed to add LengthLimit to res in killingCyclesOneStep
@lrtbuse
Copy link
Contributor

lrtbuse commented Oct 22, 2024 via email

@galettof
Copy link
Contributor

Hi Mike,

From what I can tell, the changes are fine for the HighestWeights and BettiCharacters packages.

Thank you!

@mikestillman
Copy link
Member Author

@ggsmith K3Carpets is failing: it is using CompleteIntersectionResolutions. Unfortunately, it doesn't look as trivial to modify as the other packages we have done. It uses also NonminimalComplexes, which we have not yet modified to work with Complexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants