Fix realPart/imaginaryPart/conjugate bugs #3506
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realPart
andimaginaryPart
expected one of theNumber
types defined in the interpreter, so failed when given one of theNumber
types defined at top-level (Constant
,InfiniteNumber
,IndeterminateNumber
).conjugate
assumed that every non-CC
Number
object was real, and so gave the wrong output when givenii
, which is complex but is aConstant
object.We also update the docs and add unit tests.
Before
After