Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for task-bar text color #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WillCDev
Copy link

@WillCDev WillCDev commented Nov 2, 2022

  • Add an additional optional configuration item called textColor to the Task styles to allow local overrides of of the task bar text color. This is important for accessibility to maintain contrast between BG color and text color when you have passed a light colour for the task bar background. It's also just quite useful in general.

  • Also cleaned up the task-bar-module style definitions and removed unnecessary repetition.

@AquilesOliveiraDev
Copy link

Hi guys, but it can't be done through style?

@WillCDev
Copy link
Author

WillCDev commented Nov 3, 2022

@AquilesOliveiraDev Can you elaborate your question sorry? I don't follow.
It's not possible to do it using css within the lib since I want the color to be dynamic.
It's also not possible to target via css externally as there's nothing unique about the created element or it's parent such that it can be targeted via css.

@AquilesOliveiraDev
Copy link

@WillCDev, i'm sorry. Now I understand the need for the feature. I have been using the fill attribute on the text element to do the color adjustment.

@lihualihua123
Copy link

Hello for the textColor when it will deploy to the plugin? We really need this config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants