Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lua and xml backup #165

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix lua and xml backup #165

merged 2 commits into from
Oct 22, 2024

Conversation

eloiferrer
Copy link
Member

@eloiferrer eloiferrer commented Oct 18, 2024

MaRDI Pull Request

Changes:

  • Adding Lua development packages to fix this php warning:
Warning: PHP Startup: Unable to load dynamic library 'luasandbox' 
(tried: /usr/local/lib/php/extensions/no-debug-non-zts-20210902/luasandbox 
(/usr/local/lib/php/extensions/no-debug-non-zts-20210902/luasandbox: cannot open shared object file: No such file or directory), 
/usr/local/lib/php/extensions/no-debug-non-zts-20210902/luasandbox.so (liblua5.1.so.0: cannot open shared object file: No such file or directory)) in Unknown on line 0
  • Filter namespaces in XML backup to include only those <= 3000. See NamespaceInfo.

Instructions for PR review:

  • Conceptual Review (Logic etc...)
  • Code Review (Review your implementation)
  • Checkout (Test changes locally)

Checklist for this PR:

Copy link
Member

@physikerwelt physikerwelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, but I think it would recommend to reduce the number of namespaces further.

@@ -46,9 +46,12 @@ xml_dump() {
echo
echo "XML backup"
XML_DUMP_FILE=portal_xml_backup_${DATE_STRING}.gz
# Relevant namespaces: https://portal.mardi4nfdi.de/wiki/Special:NamespaceInfo
NAMESPACES=(0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 120 121 122 123 274 275 640 641 828 829 3000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have the Wikibase items 120,122 in the XML output. this would be JSON wrapped into XML, I'm not sure if that's super useful. I think it would be better to export as TTL or JSON instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be better to export the wikibase entities as JSON, but do you know of an easy way to do that? I couldn't find it here: https://www.mediawiki.org/wiki/Manual:Backing_up_a_wiki
I think the important point is to ignore the namespaces that we currently use for Person:, Publication:, etc. I hope that that will be enough to at least fix the current problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will not be sufficient thus I'd go the other way around. If that succeeds we can include 120.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/maintenance/dumpJson.php to dump all the entities as a JSON file.

I am not sure how helpful that is for recovering purposes, though. Is there an easy way to load back all the entities to Wikibase from a JSON file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. I have not checked that. Another option is to have two files. My fear is that when the file gets too big it might take too long to restore things. The advantage of the json files is that they can be read by several other systems. This would provide an easy access path to the data in the far feature without restoring an MW instance. For the text we wrote manually, the effort would be limited. Start a MW instance and restore the pages in a few minutes. However, when it takes very long to restore things, the database imports might be the first choice.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm gonna first merge this version to test how it goes. Later I can try saving the wikibase entities in a different json file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, give it a try. I hope it completes in less than 24h.

@eloiferrer eloiferrer merged commit d8e0598 into main Oct 22, 2024
4 checks passed
@eloiferrer eloiferrer deleted the fix_lua_and_xml_backup branch October 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants