Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework housing update side menu #1107

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Rework housing update side menu #1107

wants to merge 35 commits into from

Conversation

Falinor
Copy link
Collaborator

@Falinor Falinor commented Jan 22, 2025 •
edited
Loading

  • Create a new AsideNext based on MUI’s Drawer to replace our custom Aside
  • Split housing update and note creation
  • Add AppSelectNext to replace our old AppSelect
  • Add validation schemas for housing update, note creation and identity
  • Add hasRole middleware
  • Add a transaction module to start a transaction throughout several repositories

@Falinor Falinor self-assigned this Jan 22, 2025
@Falinor Falinor added the enhancement New feature or request label Jan 22, 2025
@Falinor Falinor force-pushed the feat-update-housing-modal branch from b664060 to b27247a Compare January 22, 2025 16:42
@Falinor Falinor marked this pull request as ready for review January 23, 2025 08:22
Falinor added 26 commits January 23, 2025 09:22
@Falinor
feat(frontend): add AppSelectNext to replace AppSelect
f0fcb3c
@Falinor
feat(frontend): add AsideNext to replace Aside
c58de4f
@Falinor
feat(frontend): refactor HousingEditionSideMenu
7f7207c
@Falinor
feat(frontend): correctly set margins
9befb65
@Falinor
feat: add the mobilization tab
0e62411
@Falinor
feat(frontend): add the note tab
396e0df
@Falinor
feat(schemas): add HousingUpdatePayloadDTO’s schema
fde0b64
@Falinor
refactor(models): set some HousingUpdatePayloadDTO keys as nullable
b6b8af1
@Falinor
feat(server): implement unit of work using knex transactions
61371ee
@Falinor
feat: implement a basic housing update endpoint
f35d9db
@Falinor
feat(schemas): add the note payload schema
4e65183
@Falinor
feat(server): add hasRole middleware
1b9b9ad
@Falinor
feat(schemas): add id validator
d3134ec
@Falinor
feat: add note creation endpoint
6871a79
@Falinor
refactor(server): rename some note repository’s functions
447a69d
@Falinor
test(server): test note repository creation
41b95d6
@Falinor
refactor(server): add deprecated fields actually existing in the note…
3c9c8d1 
…s table
@Falinor
feat(server): fail note creation if the housing was not found
87eeaf6
@Falinor
feat(frontend): add note creation endpoint
79da7d4
@Falinor
refactor(server): change note kind value
263a6af
@Falinor
refactor: rename housing note list endpoint; remove listByOwnerId; re…
b44d273 
…factor listByHousingId
@Falinor
feat(frontend): add notifications on housing update and note creation…
c8f5cfa 
…; submit only if there is a change
@Falinor
feat(frontend): hide AsideNext’s backdrop
4da8158
@Falinor
feat(frontend): make AsideNext’s vertical overflow scrollable
ee9fd37
@Falinor
refactor(frontend): move housing update to the side menu component
bbcb4da
@Falinor
test(frontend): test note creation; test housing update
7f04f28
@Falinor Falinor force-pushed the feat-update-housing-modal branch from 7886518 to a44b0ca Compare January 23, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicguillois loicguillois loicguillois approved these changes

Assignees

@Falinor Falinor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Falinor @loicguillois