Use voxel manip for barrier placing commands #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-blob
commented
Jan 29, 2024
•
a-blob
commented
- This PR has been tested locally
|
Have you benchmarked that this is actually substantially faster? Barriers are a bit special because they are relatively sparse. VoxelManip can't offer sub-mapblock granularity. So with this PR, you'd be loading & setting at least 15 non-barrier blocks for each barrier block. This may very well offset any performance gains from using VoxelManip. |
|
The main problem with the current one is not speed, but that the barriers will have holes if a chunk within the selected area is not rendered when it's placing the barriers. |
LoneWolfHT
approved these changes
Jun 14, 2024
|
@LoneWolfHT I think so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.