Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimeseriesOutputOption): Allow comments after simulation options without TimeseriesOutputOption #33

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(TimeseriesOutputOption): Allow comments after simulation options without TimeseriesOutputOption #33

wants to merge 1 commit into from

Conversation

rodrperezi
Copy link

  • MODPATH config files written by ModelMuse include a comment (# some comment) after simulation options (line 3, input files).
  • Current version of MODPATH (github) throws an error when reading said comment if TimeseriesOutputOption is not specified.
  • TimeseriesOutputOption is a new input parameter not included still in newer versions of ModelMuse and eventually other writers.

@rodrperezi
fix(TimeseriesOutputOption): Allow comments after simulation options …
198f37d 
…without TimeseriesOutputOption

- MODPATH config files written by ModelMuse include a comment (# some comment) after simulation options.
- Current version of MODPATH throws an error when reading said comment if TimeseriesOutputOption is not specified
- TimeseriesOutputOption is a new input parameter not included still in newer versions of ModelMuse and eventually other writers
@aprovost-usgs
Copy link
Collaborator

@rodrperezi I am discussing with Richard Winston, the developer of ModelMuse, to determine the best way to address this in the short term and the long run.

@rodrperezi
Copy link
Author

Thanks @aprovost-usgs, the proposed (temporary?) fix make use of the 'E' added at the end of the line by URWORD in case of error, while using a negative number for the output unit (IOUT.LT.0). The error is triggered by URWORD trying to transform the comment ('#') to the integer of TimeseriesOutputOption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrperezi @aprovost-usgs