Add capability to track particles on rotated DISV MF6 grid. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Julien-K, thanks very much for looking deeper into this and making the modifications. I'll have a good look asap, and assuming it checks out I'd like to incorporate it into the upcoming release. |
|
@Julien-K, thanks again for coding this enhancement. From looking at the code, your overall approach looks sound. Would you be available to discuss it in more detail? If, so please let me know the best way to reach you in general. My email is [email protected]. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended behaviour: when a grid does not meet requirements (smoothed & rectangular):
1/ rotate the DISV grid,
2/ track particles on the rotated grid (no modifications),
3/ un-rotate the results (pathlines/endpoints/timeseries).
I did not use the (OriginX, OriginY, RotationAngle) features in the output files' headers because it might raise other issues.
Comments & improvements are welcome!