Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not all Transforms have a p_per_sample parameter #73

Open
filippocastelli opened this issue Dec 3, 2020 · 2 comments
Open

not all Transforms have a p_per_sample parameter #73

filippocastelli opened this issue Dec 3, 2020 · 2 comments

Comments

@filippocastelli
Copy link

I noticed that not all the Transforms have a p_per_sample probability parameter, is this an intended behavior for some reason?
ex: Rot90Transform has it, MIrrortransform has not.

Also noticed that this was already addressed in pull request #66
@FabianIsensee
Copy link
Member

Hi, I will look into this.
Best,
Fabian

@FabianIsensee
Copy link
Member

Hi,
can you please list the Transforms for which you would like to have a p_per_sample?
I was under the impression that if we are doing mirroring we might as well apply it uniformly to all samples. But i can see that other users would like to have more freedom. I will add it to MirrorTransform now and can also add it to other transforms of your choice.
Best,
Fabian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabianIsensee @filippocastelli