Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update for dseg/rtstruct [WIP] #99

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add update for dseg/rtstruct [WIP] #99

wants to merge 11 commits into from

Conversation

surajpaib
Copy link
Contributor

@surajpaib surajpaib commented Sep 11, 2024 •
edited
Loading

@LennyN95 PR'ing early for feedback

@LennyN95
Copy link
Member

Looks good; ultimatively, we'd ditch the json file and use the value outputs. I've a branch with preparations for sth. like @IO.Data.Input, but I feel at the current point this would be an extra overhead not meeting the derived benefit. However, it'd be great to revisit this later.

@surajpaib
Copy link
Contributor Author

@LennyN95 This would be cool to do in the long run!

For now, I will make updates for rest of the workflows and complete the PR with latest test updates

@surajpaib surajpaib marked this pull request as ready for review September 27, 2024 23:38
@surajpaib
Copy link
Contributor Author

@LennyN95 Will update the tests on zenodo as well

@surajpaib surajpaib mentioned this pull request Nov 11, 2024
Closed
@surajpaib
Copy link
Contributor Author

@LennyN95 Added files for all workflows! I think it's good to merge from my end. Supports a wide range of tested workflows now

@surajpaib
Copy link
Contributor Author

Hi @LennyN95

Could you look into merging this?

LennyN95
LennyN95 approved these changes Jan 17, 2025
View reviewed changes
models/fmcib_radiomics/utils/CentroidExtractor.py
Comment on lines +23 to +25
mask_array = sitk.GetArrayFromImage(mask)
unique_values = np.unique(mask_array)
print(f"Unique values: {unique_values}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do this only to check the metadata, right?

models/fmcib_radiomics/utils/roi.coords.schema.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LennyN95
Copy link
Member

Great! Thank you @surajpaib. I'll run the tests next week and then we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LennyN95 LennyN95 LennyN95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MHub Submissions
Status: Ready for Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajpaib @LennyN95