Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example and improved examples doc page #774

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wilfonba
Copy link
Collaborator

@wilfonba wilfonba commented Dec 24, 2024

Description

This PR makes some updates to the examples

  • Adds 2D_triple_point to examples/
  • Fixes image heights in the examples documentation page
  • Corrects the 2D Rayleigh-Taylor result on the documentation page to address "recent" bug fix

Fixes: #693

Type of change

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

@sbryngelson
Copy link
Member

Well done.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.79%. Comparing base (bdf3709) to head (019bbbb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   43.79%   43.79%           
=======================================
  Files          65       65           
  Lines       19055    19055           
  Branches     2325     2325           
=======================================
  Hits         8345     8345           
  Misses       9302     9302           
  Partials     1408     1408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Change images in examples/readme.md to have sensible sizes
2 participants