Prettify

[sbryngelson]

Prettify with CI. Uses https://gist.github.com/sbryngelson/3ddb58aa50806c0bd2c806d49bfc99ff.

Closed #282 in favor of this due to some version control nonsense.

[henryleberre]

@sbryngelson I took the liberty to tweak a few things. Let me know what you think. The main points are that ./mfc.sh format diff in its current form couldn't print a diff of what would be formatted and couldn't check the diff with the addition of the new ACC indentation script. I kept ./mfc.sh format and opted to check the diff with git diff --exit-code in CI.

In order to properly introduce ./mfc.sh format diff, we would have run both fprettify and your indenter.py in a separate directory, and finally diff the two folders.

Also, it looks like when I ran ./mfc.sh format some new things popped up. I am not sure why. They look like regressions.

[sbryngelson]

@sbryngelson I took the liberty to tweak a few things. Let me know what you think. The main points are that ./mfc.sh format diff in its current form couldn't print a diff of what would be formatted and couldn't check the diff with the addition of the new ACC indentation script. I kept ./mfc.sh format and opted to check the diff with git diff --exit-code in CI.

In order to properly introduce ./mfc.sh format diff, we would have run both fprettify and your indenter.py in a separate directory, and finally diff the two folders.

Thanks. Yes I realized this shortcoming with diff but decided that it was sufficiently good. Thanks for improving it.

Also, it looks like when I ran ./mfc.sh format some new things popped up. I am not sure why. They look like regressions.

I don't know what you're referring to

[henryleberre]

I don't know what you're referring to

If you take a look at 6c3dd9e, there are some regressions in directive indentation.

[sbryngelson]

fixed this via some additions to the formatting script. @henryleberre feel free to review and merge when ready