Linting the toolchain (#230) #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chipped away at this. i think most of the output needs to be considered somewhat more seriously now. things like unused arguments should probably be cleaned up. there are also some circular or missing imports (allegedly). |
|
@sbryngelson I fixed the rest of the issues. A few that I disabled in-place with |
henryleberre
force-pushed
the
linting
branch
3 times, most recently
from
cf47b69
to
65964e0
Compare
|
Setting as "draft" status - awaiting merging of #293. |
sbryngelson
approved these changes
Jan 5, 2024
Co-authored-by: Spencer Bryngelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #230 by linting the toolchain. I fixed many warnings but didn't address all of them.