Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump required python minor version #267

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

sbryngelson
Copy link
Member

I made it require Python 3.9. I know 3.6 doesn't work. I know 3.9 does. I do not know about 3.7 or 3.8. For the math.prod this has a documented update somewhere, but 3.6 also doesn't work once this is replaced with a 3.6-compatible command (something wrong with the subprocesses call).

Closes #265

@sbryngelson sbryngelson added the enhancement New feature or request label Dec 18, 2023
Copy link
Member

@henryleberre henryleberre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

~/MFC $ vermin --eval-annotations --backport argparse --backport dataclasses --backport typing --no-parse-comments toolchain/
Minimum required versions: 3.9
Incompatible versions:     2

@sbryngelson sbryngelson merged commit d494833 into master Dec 18, 2023
30 checks passed
JRChreim pushed a commit to JRChreim/MFC-JRChreim that referenced this pull request Dec 21, 2023
@sbryngelson sbryngelson deleted the sbryngelson-patch-2 branch January 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Minimum Python version issue?
2 participants