File Per Process IO, performance summary in docs, new example case. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbryngelson
requested changes
Dec 13, 2023
sbryngelson
reviewed
Dec 13, 2023
sbryngelson
reviewed
Dec 13, 2023
sbryngelson
reviewed
Dec 13, 2023
|
can you also fix #255 |
|
The requested changes are done. I'm having trouble getting the documentation to build locally so I can see if it actually updates on the website, but I'm working on it. |
|
@sbryngelson This should be able to merge unless you really want this PR to take care of #255. I was talking to Henry about it, and he said, and I quote, "This is a me-problem, not a you-problem" |
Lol. Fine with me. |
sbryngelson
approved these changes
Dec 14, 2023
sbryngelson
added
documentation
henryleberre
approved these changes
Dec 14, 2023
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to use file per process IO when running on very large numbers of GPUs where it was found that shared file IO wasn't very performant.
It also adds a performance summary page to the documentation that was suggested in the MFC Slack.
It also adds improved error messaging for namelist read fails in m_start_up in all three modules.
Lastly, it adds the Riemann test problem requested in #174 .