-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fmt] utils, import, viz tests #4875
Conversation
Hello @RMeli! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing fishy, good to go IMO.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4875 +/- ##
===========================================
- Coverage 93.66% 93.63% -0.03%
===========================================
Files 177 189 +12
Lines 21787 22853 +1066
Branches 3067 3067
===========================================
+ Hits 20406 21399 +993
- Misses 929 1002 +73
Partials 452 452 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrospective LGTM
📚 Documentation preview 📚: https://mdanalysis--4875.org.readthedocs.build/en/4875/