Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] utils, import, viz tests #4875

Merged
merged 1 commit into from
Dec 31, 2024
Merged

[fmt] utils, import, viz tests #4875

merged 1 commit into from
Dec 31, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Dec 29, 2024

@pep8speaks
Copy link

Hello @RMeli! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 46:80: E501 line too long (86 > 79 characters)
Line 57:9: W503 line break before binary operator
Line 58:9: W503 line break before binary operator

Line 59:17: W503 line break before binary operator
Line 60:17: W503 line break before binary operator
Line 60:21: E713 test for membership should be 'not in'

Line 43:80: E501 line too long (91 > 79 characters)
Line 60:80: E501 line too long (81 > 79 characters)

Line 71:80: E501 line too long (80 > 79 characters)
Line 86:80: E501 line too long (81 > 79 characters)
Line 189:17: W503 line break before binary operator
Line 190:17: W503 line break before binary operator
Line 197:17: W503 line break before binary operator
Line 198:17: W503 line break before binary operator
Line 312:13: W503 line break before binary operator
Line 316:13: W503 line break before binary operator
Line 320:13: W503 line break before binary operator

Line 197:80: E501 line too long (107 > 79 characters)
Line 225:80: E501 line too long (82 > 79 characters)

Line 380:9: E741 ambiguous variable name 'O'

Copy link
Member Author

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing fishy, good to go IMO.

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.63%. Comparing base (453be6c) to head (cf6eb00).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4875      +/-   ##
===========================================
- Coverage    93.66%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21787    22853    +1066     
  Branches      3067     3067              
===========================================
+ Hits         20406    21399     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RMeli RMeli enabled auto-merge (squash) December 30, 2024 13:19
@RMeli RMeli merged commit b8fe34b into MDAnalysis:develop Dec 31, 2024
25 of 26 checks passed
@RMeli RMeli deleted the fmt-utils branch January 8, 2025 21:13
Copy link
Contributor

@marinegor marinegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrospective LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants