-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'MDAnalysis.analysis.align' parallelization #4738
base: develop
Are you sure you want to change the base?
Conversation
added backends and aggregators for AverageStructure
added AverageStructure to conftest
added client_AverageStructure
added for AlignTraj backends and aggregator
added client_AlignTraj
added client_AlignTraj to tests
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2025-01-11 21:40:18 UTC |
PEP fixes
fixing PEP
fixing pep
fixing pep
fixing pep
fixing pep
fixing pep
adjusted position of inputs
fix positional arguments
added multiprocessing to test
removed multiprocessing from AlignTraj
test again
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4738 +/- ##
===========================================
- Coverage 93.66% 86.40% -7.26%
===========================================
Files 177 189 +12
Lines 21795 22874 +1079
Branches 3067 3068 +1
===========================================
- Hits 20414 19765 -649
- Misses 929 2670 +1741
+ Partials 452 439 -13 ☔ View full report in Codecov by Sentry. |
check possible fix
Fixes #4659 attempt
Changes made in this Pull Request:
backends
andaggregators
toAlignTraj
andAverageStructure
inanalysis.align
.client_AlignTraj
andclient_AverageStructure
inconftest.py
client_AlignTraj
andclient_AverageStructure
inrun()
intest_align.py
Currently for
AlignTraj
it only acceptsserial
anddask
withmultiprocessing
leading to the pytests taking forever. An additional error that appears is the following:OSError: File opened in mode: self.mode. Reading only allow in mode "r"
For
AverageStructure
the Failure that appears is the following:AttributeError: 'numpy.ndarray' object has no attribute 'load_new'
Which leads me to believe that
AverageStructure
can not be parallelized, but I would need additional opinions on it and onAlignTraj
:)PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4738.org.readthedocs.build/en/4738/